[PATCH 1/2] flex: Avoid REJECT name conflict.

Martin Mares mj at ucw.cz
Thu Apr 29 17:57:44 CEST 2010


> Right, neither is an ideal fix but at least mine is "correct" and doesn't
> cause REJECT to be defined inside flex, causing warnings.
> I don't understand your reasoning, you rather keep the buggy REJECT
> instead of renaming the bison token REJECT to Reject because it
> doesn't look as "pretty" anymore?

Why exactly do you consider the REJECT buggy? Does the documentation of flex
forbid redefinition of REJECT?

Sure, it is not elegant and it might cause bugs in the future (currently, I do
not see any real bug), but your rename is not elegant either.

				Have a nice fortnight
Martin `MJ' Mares                          <mj at ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
main(){char *s="main(){char *s=%c%s%c;printf(s,34,s,34);}";printf(s,34,s,34);}

More information about the Bird-users mailing list