Patch for renaming sk_new()

Ondrej Zajicek santiago at crfreenet.org
Tue Jun 12 12:16:33 CEST 2012


On Fri, Jun 08, 2012 at 02:38:45PM -0700, Wes Hardaker wrote:
> 
> The sk_new() function within bird is identically named to an openssl
> function.  We needed to link against openssl to support BGPSEC, which
> Michael Baer wrote you about back in March, so I wrote a short patch to
> rename sk_new() to sk_new_sock() instead.  It's attached below and I'd
> love it if it could be applied to the primary repository.

Hmm, using such generic prefix like sk_ in public library like OpenSSL
is definitelyt not a good idea on their side, but i guess we have to
make a change to be able to link to it. I would prefer less intrusive
patch like the attached one (keeping sk_new() name using macro). Try it
and let us know whether it is OK for your purpose (you have to just
#undef sk_new before including OpenSSL in files that use OpenSSL).

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20120612/f0c753e2/attachment-0001.asc>


More information about the Bird-users mailing list