[PATCH 1/2] flex: Avoid REJECT name conflict.

Martin Mares mj at ucw.cz
Thu Apr 29 19:23:22 CEST 2010


Hello!

> No, but it is the equivalent of renaming a variable from an ideal name
> to a less ideal name, not a big deal.

It's called breaking invariants. So far, all tokens were named in a uniform,
systematic way. Your patch breaks it. Hence your patch is buggy.

Do not fix a problem by introducing another.

Generally speaking, your bug reports are very welcome, but patches which
offer ugly kludges as solutions not so much.

				Have a nice fortnight
-- 
Martin `MJ' Mares                          <mj at ucw.cz>   http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
98% of the time I am right. Why worry about the other 3%



More information about the Bird-users mailing list