[PATCH v2] conf: only offer bfd in bgp if bfd protocol is enabled

[Ondrej Zajicek]

On Fri, May 24, 2024 at 02:54:03PM +0200, Yuri Honegger via Bird-users wrote:
> When trying to build bird with bfd support disabled (e.g. ./configure --with-protocols=bgp,static), it fails since the bgp configuration code expects bfd to be around.
> 
> This patch makes the bfd option in the bgp protocol unavailable using some preprocessor logic if we are building without bfd.

Hi

Thanks for the patch. Build failure with BFD disabled is clearly a bug.
Using Make functions to define M4 macros to control Bison grammars seems
like a little bit complex solution, so i just fixed it on Bison level by
moving bfd_opts grammar to the appropriate place:

https://gitlab.nic.cz/labs/bird/-/commit/e29f134ad9346343277b7cb4581d2a704592dc79

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
"To err is human -- to blame it on a computer is even more so."