RPKI protocol is loop starting if the min version is not available

[Job Snijders]

On Mon, Dec 16, 2024 at 10:59:06PM +0100, Alarig Le Lay via Bird-users wrote:
> > Also it is funny that Routinator answered with: 'only versions 0 up
> > to and including MAX_VERSION supported' without stating what is the
> > MAX_VERSION.
> 
> You tell me, that’s not a very useful error message :p

The code that produces the error is here:
https://github.com/NLnetLabs/rpki-rs/blob/aa74957aa2965108ea18adb0c0b81861deb3e11b/src/rtr/server.rs#L343-L356

MAX_VERSION is defined here:
https://github.com/NLnetLabs/rpki-rs/blob/aa74957aa2965108ea18adb0c0b81861deb3e11b/src/rtr/server.rs#L20-L29

Copy+pasting:

"""
	//============ Constants =====================================================
	/// The maximum protocol version we support.
	///
	/// We support all protocol versions from 0 up to and including this value.
	///
	/// While the server technically supports version 2 as well, the format of the
	/// ASPA PDU has not yet been agreed upon. Rather than possibly deploying
	/// broken servers, we only announce support for version 0 or 1 for now.
	const MAX_VERSION: u8 = 1;
"""

Indeed, I agree with the comment, the RTR protocol has not yet been
agreed upon.

So for similar reasons, I effectively disabled ASPA in the StayRTR
implementation a few months ago:
https://github.com/bgp/stayrtr/commit/cef0a53aadb4edf99db16679514e36fb0ff7d41c

I very recently compiled a list of open todo items to move ASPA / RTR
forward here: https://mailarchive.ietf.org/arch/msg/sidrops/fwPjecfnlU5JYi_hU-Sh3o7WRHQ/

Kind regards,

Job