Pending bird patches and discussions for proto/babel

Toke Høiland-Jørgensen toke at toke.dk
Thu Jun 1 23:21:36 CEST 2023


Daniel Gröber <dxld at darkboxed.org> writes:

> Hi Maria,
>
> On Thu, Jun 01, 2023 at 05:33:42PM +0200, Maria Matejka via Bird-users wrote:
>> > Toke's first two patches are ready for merging, but the third (metric
>> > smoothing) is contested since it conflicts with my route selection patch in
>> > its current form and if adapted it conflicts with my scalability goals for
>> > babel instead. Possibly premature optimization admittedly ;)
>> 
>> We generally thought that the patches were still kinda work in progress,
>> sorry if our non-responsivity could be interpreted as negligence.
>
> No worries, I figured that's what was going on.
>
>> > That being said since RTT metric is a new feature anyway I would prefer we
>> > just go with my route damping approach, mark RTT as experimental and get
>> > some more wider testing through a released version.
>>
>> That looks like a feasible way to go. Shall we then just try to merge these
>> patches as they have been sent to the list?
>
> I have some more changes to make to the dampening patch, but if we're in
> agreement that this direction is the way to go I'll get a v1 out ASAP.
>
> You can merge Toke's patches independently of that though. RTT without
> smoothing is still useful :)

Yeah, I'm OK with just merging patches 1-2 of the 3-patch series I sent
back in March :)

-Toke



More information about the Bird-users mailing list