[PATCH] Filter: Add support for setting TCP congestion control algorithm

[Ondrej Zajicek]

On Thu, Mar 17, 2022 at 05:32:02PM -0600, Trisha Biswas wrote:
> Add support for setting the TCP congestion control algorithm per
> destination by
> 
> modifying route attributes in BIRD. Previously supported kernel route
> attributes
> 
> in BIRD were all integer values. Subsequently, this also adds string
> handling of
> 
> kernel metrics.

Hi

We are currently redesigning attribute types in order to have direct
matching between attribute and filter types. And considering that string
type is not currently implemented in attributes and it is a special case
that have a different representation in both (direct ptr vs adata), we will
postpone this patch after the redesign and then merge relevant parts of
your patch.

Otherwise, the patch is ok and the feature is worth merginh, i would just
change it to add generic string type EAF_TYPE_STRING instead of
EAF_TYPE_CC_ALGO.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."