2.0.9 babel interfaces removed after configure

[Ondrej Zajicek]

On Fri, Feb 25, 2022 at 02:55:35AM +0100, Johannes Kimmel wrote:
> Hi,
> 
> with bird 2.0.9 previously configured babel interfaces are removed after
> `birdc configure`.
>
> ...
>
> As you can see, without changing the config file, the babel interface
> disappears after reconfiguring bird.
> 
> It was suggested to me (thanks nixxda!) that the bug may have been
> introduced in [1], specifically in line 1757:
> 
> +    if (ic && iface_is_valid(p, iface))
> +      ic = NULL;
> 
> The issue might be a missing negation before `iface_is_valid`, though I have
> not confirmed it myself.

Hi

Thanks for bugreport, you are right.  Will fix that.

That is unfortunate. We already added automatic tests for Babel
reconfiguration, but that was done after that commit and test data
were already poisoned by the bug.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."