bgp keepalive & hold timers

[Alexander Zubkov]

For example bird can check that the hold timer proposed by a peer is
at least 2 times greater than the local keepalive timer as in the
attached patch.


On Mon, Apr 11, 2022 at 1:12 PM Alexander Zubkov <green at qrator.net> wrote:
>
> Hi,
>
> Found interesting thing. If I set "keepalive time" for a BGP session,
> this values is not modified after the hold time negotiations and as a
> result I can get a BGP session with hold timer less than keepalive
> timer and it will die due to hold timer expired after some time.
> https://gitlab.nic.cz/labs/bird/-/blob/692055e3df6cc9f0d428d3b0dd8cdd8e825eb6f4/proto/bgp/packets.c#L908
> I think more correct bahivour would be to close the BGP session with
> unacceptable hold timer error in such case.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bird-bgp-check-ka-timer.patch
Type: application/x-patch
Size: 412 bytes
Desc: not available
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20220418/40979ba2/attachment.bin>