Bug: BFD confuses sessions with identical IPv6 link-local addresses

[Ondrej Zajicek]

On Fri, Apr 10, 2020 at 11:13:40AM +0200, Sebastian Hahn wrote:
> > Thanks for the bugreport. You are right, BFD sessions are dispatched just based
> > on source address regardless of interface, so it is confused by conflicting
> > link-local addresses. We will fix that, i would expect the same issue could
> > happen when conflicting private IPs are used in different VRFs.
> 
> in the meantime I thought I might try my hand at a patch, as attached here.
> It seems to work for me in some limited form of testing. I'll be happy to
> do any and all kinds of revisions as required of course.

Hi

(Noticed while looking for some missed / forgotten e-mails)

Thanks for the patch, merged with some changes (fixed multihop BFD and hashing):

https://gitlab.nic.cz/labs/bird/-/commit/910adaa08bbd416288797505399ab47f990817e6

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20210114/cd60e786/attachment.sig>