[PATCH] BGP: Log value of invalid NEXT_HOP in bgp_apply_next_hop()

[Ondrej Zajicek]

On Sat, Dec 11, 2021 at 09:22:46AM +0100, Simon Ruderich wrote:
> ---
> Hello,
> 
> while debugging "Invalid NEXT_HOP attribute" messages in my setup
> I had to recompile bird2 with additional debug output to
> determine which BAD_NEXT_HOP line was triggered and with which
> NEXT_HOP value. After adding this patch determining the problem
> was very easy.
> 
> I also looked at the other BAD_NEXT_HOP in the file but I'm not
> sure how to properly print their values.

Hello

I see that 'Invalid NEXT_HOP attribute' is kind of cryptic message,
considering that it may happen for several different reasons, both in
rx and tx path, and everything is more complicated by the IPv6 dual
next-hop addresses (global and link-local). I will make some
modifications to show proper reasons and next-hop values in all cases.

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."