OSPF stuck in 2-way state

[Kenth Eriksson]

On Tue, 2019-10-08 at 11:34 +0200, Ondrej Zajicek wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> On Tue, Oct 08, 2019 at 07:53:53AM +0000, Kenth Eriksson wrote:
> > On Tue, 2019-10-08 at 06:45 +0000, Kenth Eriksson wrote:
> > > On Mon, 2019-10-07 at 18:34 +0200, Ondrej Zajicek wrote:
> > > > On Mon, Oct 07, 2019 at 02:38:13PM +0000, Kenth Eriksson wrote:
> > > > > > The prio change is user driven, the user changed from prio 0 to 5 and
> > > > > > then re-configured. So now bird has prio 5 and quagga 0. Initially both
> > > > > > ends had prio 0.
> > > > > > 
> > > > > Shouldn't the interface state machine be kicked when interface priority
> > > > > is changed? E.g. from ospf_iface_reconfigure, invoke ospf_iface_sm with
> > > > > state ISM_NEICH?
> > > > 
> > > > See commit fa1e0ba35416561bda3708ec808d24641dd8995f (fixed in 2.0.5)
> > > > 
> > > That fix is included in 2.0.5 but not in 2.0.6. Did you revert the fix
> > > after that?
> > > 
> > I noticed now that the fix is included in your gitlab version of 2.0.6.
> > Did you by any chance move the 2.0.6 tag?
> 
> If i remember correctly, we mistakenly released v2.0.6 tag pointing to some
> older release (2.0.4?), then fixed it.
> 
> Proper 2.0.6 release commit is 5235c3f78da15826b0654ba68dc7a897faa42c98 .
> 
> What commit do you use? You can also check NEWS to see last version.
> 
The broken 2.0.6 tag I had locally was
3a22a6e858cd703d254ab331183ccd56fe195c6b, which is only six commits
after 2.0.4. But I have now deleted that erroneous tag and fetched
again. 

Thanks for confirming my suspicion about a faulty 2.0.6 tag, but next
time please try to avoid rebasing/rewriting git history...  I recall I
had a similar problem when you moved from github to gitlabs.

> --
> Ondrej Santiago Zajicek