[PATCH 1/9] Adding configuration option --enable-sadr.

[Dean Luga]

I used the configure switch since SADR makes changes to the LSAs and it
will slightly impact network traffic even with source 0::/0. If someone
doesn't want that, they can disable it.

About the name, you are right, it should be changed.

On 7 Mar 2017 10:32, "Toke Høiland-Jørgensen" <toke at toke.dk> wrote:

Dean Luga <dluga93 at gmail.com> writes:

> From: dean <dluga93 at gmail.com>
>
> It compiles with the macro SADR_OSPF defined.

Quick comment (I'll look over the rest in more detail later): Why is
source address routing guarded by a configure switch? Shouldn't Bird be
able to understand source-specific routing always, and have the use of
them be configurable at runtime?

>
> +if test "$enable_sadr" = yes ; then
> +  CPPFLAGS="$CPPFLAGS -D SADR_OSPF"
> +fi
> +

See above; but if you *are* going to have a config flag, should it maybe
be something that doesn't have the name of a protocol in it (since there
will be other protocols supporting SADR routing)? :)

-Toke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20170307/35816f96/attachment.html>