Version 1.6.0

[Jan Matejka]

On 05/02/2016 12:12 PM, Ondrej Zajicek wrote:
> On Mon, May 02, 2016 at 10:44:28AM +0200, Jan Matejka wrote:
>>> In function 'strncpy',
>>>     inlined from 'rip_fill_authentication.isra.9' at ../../../proto/rip/packets.c:215:5:
>>> /usr/include/bits/string3.h:126:10: error: call to __builtin___strncpy_chk will always overflow destination buffer
>>>    return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
>>>           ^
>>> make[1]: *** [packets.o] Error 1
>>
>> Thanks for your report, we will address it, it seems to be a real bug in
>> auth.
> 
> Well, IMHO it is not a bug but a false positive, see:
> 
> http://bird.network.cz/pipermail/bird-users/2015-October/009966.html
> 
> Although we could use there some less tricky construct.

Definitely. It looks really strange. Maybe some union may help or at
least an explaining comment. This is possibly another place where strict
aliasing could fail ...

MQ