BIRD-1.3.6 - show bgp summary command

[Alexander Shikoff]

Hello!

On Mon, Feb 27, 2012 at 10:07:26PM +0400, Alexander V. Chernikov wrote:
> On 27.02.2012 21:31, Alexander Shikoff wrote:
> > Hello List,
> >
> > On Mon, Feb 27, 2012 at 11:41:53AM +0100, Ondrej Zajicek wrote:
> >> On Sat, Feb 25, 2012 at 03:33:13PM +0200, Alexander Shikoff wrote:
> >>> On Thu, Feb 23, 2012 at 04:48:00PM +0200, Dean Belev wrote:
> >>>> Hi there,
> >>>>
> >>>> Is the patch for 1.3.4
> >>>> (http://marc.info/?l=bird-users&m=132155489919052&w=2
> >>>> <http://marc.info/?l=bird-users&m=132155489919052&w=2>) usable for 1.3.6 ?
> >>>>
> >>>> We have a strange behavior when we tried to implement it for 1.3.6 - the
> >>>> process stops right after the Enter is triggered.
> >>>> But the "?" function works correctly.
> >>>
> >>> Old patch does not fit the source code and bird architecture as well.
> >>> I've changed it in order to more comply to a birdc syntax.
> >>
> >> To fit better with BIRD architecture, it would be perhaps better to
> >> remove that from hooks and global code and move it completely to BGP
> >> code (like 'show ospf' is in OSPF code) and name it something like
> >> 'show bgp summary'.
> >
> > Yes, you're right. I'm going to modify a patch, but I'm wondering
> > what is the best way to get a list of all BGP protocols?
> >
> > The only way I know at a moment is just walking through proto_list
> > and comparing proto name to "BGP". Is there a better way?
> You have to walk through all protocols, yes. However, comparison is a 
> bit simpler. You can take a look into bgp_incoming_connection() for more 
> details.

Thank you Ondrej and Alexander for pointing me.
Universal patch for both IPv4 and IPv6 sources is attached.
Reviews and comments are kindly appreciated.


Example outputs:

# birdc6
BIRD 1.3.6 ready.
bird> show protocols
name     proto    table    state  since       info
device1  Device   master   up     2012-02-28 12:29:44  
ITCONSULTING BGP      master   up     2012-02-28 12:30:16  Established   
CITYNET  BGP      master   start  2012-02-28 12:29:44  Passive       
bird> show bgp ?
show bgp summary [<name>]                      Show BGP peers summary
bird> show bgp summary CITYNET
Peer
         AS Last state change   Prefixes rcvd/best   State/Last error
2001:7f8:63::39
      16066 2012-02-28 12:29:43 0/0                  Passive       
bird> show bgp summary        
Peer
         AS Last state change   Prefixes rcvd/best   State/Last error
2001:7f8:63::11
      25372 2012-02-28 12:30:15 1/1                  Established   
2001:7f8:63::39
      16066 2012-02-28 12:29:43 0/0                  Passive       
bird> 


# birdc
BIRD 1.3.6 ready.
bird> show protocols 
name     proto    table    state  since       info
device1  Device   master   up     2012-02-28 12:31:44  
ITCONS   BGP      master   up     2012-02-28 12:33:00  Established   
UOS      BGP      master   start  2012-02-28 12:33:29  Passive       Received: Peer de-configured
BOOM     Static   master   up     2012-02-28 12:31:44  
bird> show bgp summary BOOM
BOOM: Not a BGP protocol
bird> show bgp summary ITCONS
Peer                    AS Last state change   Prefixes rcvd/best   State/Last error
193.25.180.17        25372 2012-02-28 12:33:00 2/2                  Established   
bird> show bgp summary       
Peer                    AS Last state change   Prefixes rcvd/best   State/Last error
193.25.180.17        25372 2012-02-28 12:33:00 2/2                  Established   
193.25.180.26        42546 2012-02-28 12:33:29 0/0                  Passive       Received: Peer de-configured
bird> 

-- 
MINO-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-show-bgp-summary.diff
Type: text/x-diff
Size: 3362 bytes
Desc: not available
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20120228/a1499be7/attachment-0001.diff>