bird patches review

[Ondrej Zajicek]

On Mon, Oct 03, 2011 at 10:03:30PM +0400, Alexander V. Chernikov wrote:
>>> In most hardware routers (and even in Quagga) it is possibly to see if
>>> RIB entry is installed to FIB
>>> (e.g. * ). Maybe kernel can set some flag at least when it sees
>>> installed prefix gets removed from kernel table?
>>> (or adds some flags on route installation and remove it on route removal)
>>>      
>> There is already such flag (because kernel sync is a bit tricky and abuses
>> routing table to rememer its state), perhaps we could show that flag in
>> some way.
>>
>>    
> Should I [as usual] submit patch for that? :)

I found that the flag signalizes whether route is expected to be
installed (but the installation might failed). I added the flag
signalizing that the last attempt to install the route to the kernel
table failed, and showed that flag in 'show route':

bird> show route 
10.200.0.0/16      via xx.xx.xx.xx on eth0 [static1 16:13] ! (200)
192.168.0.0/16     via xx.xx.xx.xx on eth0 [static1 16:13] * (200)
10.220.0.0/16      via xx.xx.xx.xx on eth0 [static1 16:13] * (200)

Showing just whether the route is (supposed to be) installed seems
a bit pointless - it is usually 'export all' or 'export none' for
kernel protocol. If someone removes the route from FIB (kernel)
and BIRD notices that, it reinstalls the route, so unless there
is a problem in route installation, it remains synced.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20111006/ce9d80aa/attachment.asc>