[PATCH] protocol templates

[Alexander V. Chernikov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ondrej Zajicek wrote:
> On Sat, Oct 29, 2011 at 02:24:27AM +0400, Alexander V. Chernikov wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hello list!
>>
>> Patch permits templates generation via 'template' keyword. Protocols can
>> inherit templates (and templates can inherit templates) via 'inherit'
>> keyword. At the moment patch supports BGP only (however adding other
>> protocols is trivial)
> 
> Great. Just one major comment - 'inherit' keyword inside a body of
> protocol is (IMHO) not a good idea - it looks like option but it
> is really something different (meta-option) and also silently
Well, (from my point of view) it is really the general protocol option,
like any other, changing some protocol options.
> overwrites every option used before that (if not used first
> in the body).
We can easily enforce check for 'inherit' to be the very first option in
protocol block

> 
> protocol bgp rr_cl_ft by rr_client_bb {
>   neighbor 10.4.7.2 as 65000;
> }
> 
> (Not being native english speaker i am not sure whether 'by'
> is really the most apt keyword, any comments on that? Perhaps
> 'from'?)
Unfortunately I'm not a native speaker, too :(
Maybe someone ?

Personally I prefer 'inherit' keyword (either inside or in protocol
block definition) since it is self-explaining (instead of 'by' or 'from')
> 
> I will update the patch and merge it soon.
> 

Great!

P.S.
And what about other patches? :)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6xqEcACgkQwcJ4iSZ1q2nLTwCcDFKKJII/ItNBRJFR2LFaFwiW
154An1X/mvA1j7o6wFmaJXJ5Lr/Zu+na
=gjm4
-----END PGP SIGNATURE-----