1.3.0, zero BGPID on OpenBSD

[Stuart Henderson]

Hi, I was just looking at updating the OpenBSD port and noticed
that bird is sending a zero BGPID, so OpenBGP refuses to talk to
it.

The router ID of my test box is correctly being shown here:

bird> show status 
BIRD 1.3.0
Router ID is 85.158.44.149
Current server time is 31-03-2011 23:12:59
Last reboot on 31-03-2011 23:06:47
Last reconfiguration on 31-03-2011 23:06:47
Daemon is up and running

...but it doesn't make it into the BGP OPEN. Capture/decode of
the OPEN message below, this is running on -current OpenBSD/amd64
(i.e. in 64-bit mode). This did work without additional config
in 1.2.5.

(Also noticed a minor unrelated nit that doesn't really warrant
a separate mail, the sample config still lists the old format
"multihop 20 via 62.168.0.13;")

regards,
Stuart


Border Gateway Protocol
    OPEN Message
        Marker: 16 bytes
        Length: 45 bytes
        Type: OPEN Message (1)
        Version: 4
        My AS: 61006
        Hold time: 240
        BGP identifier: 0.0.0.0
        Optional parameters length: 16 bytes
        Optional parameters
            Capabilities Advertisement (16 bytes)
                Parameter type: Capabilities (2)
                Parameter length: 14 bytes
                Multiprotocol extensions capability (6 bytes)
                    Capability code: Multiprotocol extensions capability (1)
                    Capability length: 4 bytes
                    Capability value
                        Address family identifier: IPv4 (1)
                        Reserved: 1 byte
                        Subsequent address family identifier: Unicast (1)
                Route refresh capability (2 bytes)
                    Capability code: Route refresh capability (2)
                    Capability length: 0 bytes
                Support for 4-octet AS number capability (6 bytes)
                    Capability code: Support for 4-octet AS number capability (65)
                    Capability length: 4 bytes
                    Capability value
                        AS number: 61006

0000  00 0c 29 30 0d 61 00 1b 21 2d f7 0c 08 00 45 c0   ..)0.a..!-....E.
0010  00 61 77 75 40 00 0a 06 f3 fe 55 9e 2c 95 55 9e   .awu at .....U.,.U.
0020  2c 92 5d 2a 00 b3 0b 3f 80 f8 49 50 cb a1 80 18   ,.]*...?..IP....
0030  08 00 e6 5e 00 00 01 01 08 0a ac 6b 48 b4 ae b7   ...^.......kH...
0040  79 43 ff ff ff ff ff ff ff ff ff ff ff ff ff ff   yC..............
0050  ff ff 00 2d 01 04 ee 4e 00 f0 00 00 00 00 10 02   ...-...N........
0060  0e 01 04 00 01 00 01 02 00 41 04 00 00 ee 4e      .........A....N