[PATCH 1/2] flex: Avoid REJECT name conflict.

Joakim Tjernlund joakim.tjernlund at transmode.se
Wed Apr 28 09:07:29 CEST 2010


>
> Martin Mares <mj at ucw.cz> wrote on 2010/04/27 23:47:01:
> >
> > Hello!
> >
> > > > Again, the fix is uglier than the symptoms of the problem.
> > >
> > > Picky, you rather stare at that warning and the ugly
> > > #undef REJECT plus some potential bug yet to be found?
> >
> > No, I would rather like to commit a proper fix, not an ugly hack,
> > which tries to fix something which has never bitten anybody yet.
>
> That choice does exist yet unless you plan to do it?
> This bug must have been there forever and no one has
> bothered to fix it yet so I don't think there will be one
> anytime soon. Meanwhile, this is a better workaround
> than the current one.

While we are in cf-lex.l, this looks like a bug:

diff --git a/conf/cf-lex.l b/conf/cf-lex.l
index 82f4c52..b1a60e4 100644
--- a/conf/cf-lex.l
+++ b/conf/cf-lex.l
@@ -111,7 +111,7 @@ WHITE [ \t]
 #endif
 }

-0x{DIGIT}+ {
+0x{XIGIT}+ {
   char *e;
   long int l;
   errno = 0;




More information about the Bird-users mailing list