[PATCH 1/2] flex: Avoid REJECT name conflict.

Joakim Tjernlund joakim.tjernlund at transmode.se
Tue Apr 27 23:44:11 CEST 2010


Martin Mares <mj at ucw.cz> wrote on 2010/04/27 23:34:18:
>
> Hello!
>
> > I noticed the compile warning caused by it and looked for the
> > reason. I didn't notice any problem but such conflicts are a bug
> > waiting to happen so I tried to fix it.
>
> Again, the fix is uglier than the symptoms of the problem.

Picky, you rather stare at that warning and the ugly
#undef REJECT plus some potential bug yet to be found?

That also limits some options to flex as it complains that
REJECT is already in use(or some such, can't remember the exact message)

>
> > The best fix would be to prefix all tokens(say TOK_) so
> > one doesn't risk conflicts
>
> This looks like the proper way.

Yes, but that is over my head. Something for you guys that
speak m4.

 Jocke




More information about the Bird-users mailing list