[PATCH] ipsum_calc_block: Optimize size and speed

Joakim Tjernlund joakim.tjernlund at transmode.se
Fri Apr 23 19:40:28 CEST 2010


Martin Mares <mj at ucw.cz> wrote on 2010/04/23 19:23:18:
>
> Hello!
>
> > > > So there isn't really difference in performance of both
> > > > implementations. Even on slow embedded AMD Geode CPU, it gives
> > > > ~ 180 MB/s.
> >
> > No difference? what does 1.2 mean? to me this means 20% which is a lot
>
> Yes, but according to Santiago's benchmarks, your code is sometimes 20%
> faster, sometimes 20% slower. It does not seem like a reason for change.

uhh, 20% slower? Ahh now I see, the MIPS. That is really strange. Santiago, are
you sure that is not a typo?

>
> If you have any benchmark showing that BIRD spends a substantial amount
> of time in this function, let's optimize it properly, even if it means
> having several versions for different CPU's. Otherwise, let us stick
> with the current code and concentrate our effort on places which matter.

Peformance matter, especially when the network grows. Is this the way
BIRD development works? Only work on stuff that currently feels important
is acceptet?

 Jocke




More information about the Bird-users mailing list