Bugs related to ptp links

[Ondrej Zajicek]

[ The first email does not come, resending. ]

Hello

The code generating LSAs for ptp ospf links is buggy.
The current behavior is that it generates
ptp link if there is a full/ptp neighbor and
stub link if there isn't. According to RFC 2328, the
correct behavior is to generate stub link in both
cases (in the first case together with ptp link).

And because of buggy detection of unnumbered networks,
for numbered networks the code creates stub links
with 0.0.0.0/32.

The first patch corrects this behavior, but i am not
sure what is the best behavior for unnumbered
(ptp-address) networks. The code contains variable
ptp_unnumbered_stub_lsa that determines whether
unnumbered ptp links should generate stub links.
If enabled, stub links are generated regardless
there is a full/ptp neighbor.

The second patch makes an ospf dump more informative.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 010_ptp_lsa_fix.patch
Type: text/x-diff
Size: 2819 bytes
Desc: not available
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20080824/848884ae/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 011_topology_dump.patch
Type: text/x-diff
Size: 2064 bytes
Desc: not available
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20080824/848884ae/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20080824/848884ae/attachment-0001.asc>