Patch for IPv6 ECMP support?

[Neil Jerram]

I've been looking at v2 of this patch, and have not been able to understand
the operation of the for loop in these lines from mpnh_sort:

          ret = mpnh_copy_lp(x, lp);

          for (old_prev = x, new_prev = ret;
                    old_prev != prev;
                    old_prev = old_prev->next, new_prev = new_prev->next);

I'm probably being stupid - but can someone explain how that for loop works?

Thanks,
     Neil


On Mon, Aug 22, 2016 at 11:21 AM Neil Jerram <neil at tigera.io> wrote:

> Hi Mikhail,
>
> I don't want to sound ungrateful, but that sounds a bit odd.  Is something
> stopping you from posting the updated patch immediately?  I would really
> appreciate it today, or as soon as possible after that.
>
> Best wishes,
>       Neil
>
>
> On Sun, Aug 21, 2016 at 8:19 PM Mikhail Sennikovskii <
> mikhail.sennikovskii at profitbricks.com> wrote:
>
>> Hi Michael, Neil and all,
>>
>> Thanks for you interest in the patch. I'll try to post the updated patch
>> version within the next few days.
>>
>> Mikhail
>>
>> 2016-08-20 2:55 GMT+03:00 Michael Elkins <me at sigpipe.org>:
>>
>>> On Thu, Aug 18, 2016 at 06:39:24PM +0200, Arno Töll wrote:
>>>
>>>> Having that said, I am aware of at least another issue related to the
>>>> route scan after an ECMP export, which we fixed internally in v3. In
>>>> lack of interest, we did not bother to send it upstream so far.
>>>> However, I will ask Mikhail to send it tomorrow, or I will do, so that
>>>> other interested folks can at least find it on the list.
>>>>
>>>
>>> Arno,
>>>
>>> I also wanted to voice interest in this work.  I've been testing the v2
>>> patch, and I've encountered the bug you described (the multipath route gets
>>> installed initially, but bird subsequently reports a sync error, and the
>>> debug log indicates the multipath route is attempting to be reinstalled
>>> indefinitely with error).
>>>
>>> Regards,
>>>
>>> Michael
>>>
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20160822/bd393c76/attachment.html>