BIRD 1.4.0 bugfixes [2/2]

[Pierluigi Rolando]

> Thanks, the analysis and the patch is more-or-less correct, with one
> minor note:
> 
> >        for (r2 = r->mp_next; r2; r2 = r2->mp_next)
> > -	if (r2->installed)
> > +	if (r2->installed > 0)
> >  	  {
> >  	    struct mpnh *nh = alloca(sizeof(struct mpnh));
> >  	    nh->gw = r2->via;
> 
> No need for this change, secondary multipath nodes from mp_next cannot
> be -1, they are not modified in static_match() but in static_add() and
> the meaning is slightly different.

Understood. I've never tried multipath routes so that bit was untested.

I've also tried the patch you've attached to fix the TMP_DOWN issue and so far it's working well.

Thanks,
Pierluigi