Patch ping

Ondrej Zajicek santiago at crfreenet.org
Tue Apr 27 23:00:12 CEST 2010


On Tue, Apr 27, 2010 at 10:29:21PM +0200, Martin Mares wrote:
> Hello!
> 
> > Although i don't like the patch, i can't find a better way to fix this
> > so i will probably merge that.
> > 
> > MJ, do you have some comment on this [*]?
> > 
> > [*] http://marc.info/?l=bird-users&m=127200916013140&w=2
> 
> I am getting Internal Server Error at this URL now. Do I guess correctly that
> it is the patch changing calls of ld to calls of cc?

diff --git a/tools/Rules.in b/tools/Rules.in
index 79a15fa..e4598e2 100644
--- a/tools/Rules.in
+++ b/tools/Rules.in
@@ -66,7 +66,7 @@ else
 subdir: all.o
  
 all.o: $(objs)
-	$(LD) -r -o $@ $^
+	$(CC) -nostdlib  -Wl,-r -o $@ $^

> I suspect that "-nostdlib" and "-Wl" are much less portable than the previous
> construct with ld (they look like GCCisms to me). Joakim, have you
> investigated that?

This is no issue, we already require GCC.

-- 
Elen sila lumenn' omentielvo

Ondrej 'SanTiago' Zajicek (email: santiago at crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://trubka.network.cz/pipermail/bird-users/attachments/20100427/6a01502f/attachment-0001.asc>


More information about the Bird-users mailing list